Re: [PATCH 1/2] KDB: Make LINES an internal variable.

[Andrei Warkentin]

Hi,

----- Original Message -----
> From: "Andrei Warkentin" <andreiw@xxxxxxxxxx>
> To: kgdb-bugreport@xxxxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx, "jason wessel" <jason.wessel@xxxxxxxxxxxxx>, andreiw@xxxxxxxxxx
> Sent: Friday, February 17, 2012 9:07:15 PM
> Subject: [PATCH 1/2] KDB: Make LINES an internal variable.
> 
> 1) If you run 'dumpall', LINES will remain set to
>    10000, and you might wonder why dmesg now doesn't
>    page.
> 2) If you run any command that sets LINES, you will
>    eventually exhaust the heap.
> 
> To address (1), you can save and restore across
> calls to "defcmd" commands, which might contain
> "set LINES". This becomes awkward with keeping
> LINES in env, but there is no real reason why
> LINES cannot be treated as an internal variable.
> Additionally, you get rid of the (small) kdb heap
> usage for LINES.
> 

Does any of this make sense :-)?

A
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/