Re: [PATCH, v2] x86-64: fix CFI annotations for NMI nesting code

From: Steven Rostedt
Date: Fri Feb 24 2012 - 11:47:22 EST


On Fri, 2012-02-24 at 14:54 +0000, Jan Beulich wrote:
> The saving and restoring of %rdx wasn't annotated at all, and the
> jumping over sections where state gets partly restored wasn't handled
> either.
>
> Further, by folding the pushing of the previous frame in repeat_nmi
> into that which so far was immediately preceding restart_nmi (after
> moving the restore of %rdx ahead of that, since it doesn't get used
> anymore when pushing prior frames), annotations of the replicated
> frame creations can be made consistent too.
>
> v2: Fully fold repeat_nmi into the normal code flow (adding a single
> redundant instruction to the "normal" code path), thus retaining
> the special protection of all instructions between repeat_nmi and
> end_repeat_nmi.

Thanks, I'll start testing it.

>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Steven Rostedt <srostedt@xxxxxxxxxx>

FYI, please send to my rostedt@xxxxxxxxxxx account. My RH account is a
second class citizen that I use to read RH status updates and such. I
don't conduct upstream work from it and I may ignore it for long periods
of time.

I author code with it just to give credit to the company that pays me,
but my SOB is always the goodmis.org account.

Thanks,

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/