[PATCH v2] regulator: Set delay to 0 if set_voltage_time_selcallback returns error

From: Axel Lin
Date: Fri Feb 24 2012 - 10:05:05 EST


rdev->desc->ops->set_voltage_time_sel may return negative error code.
Set delay to 0 and also show warning if set_voltage_time_sel returns error.

Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
---
v2: show warning message if set_voltage_time_sel returns error.

drivers/regulator/core.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index beeeb7f..19a4778 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1892,6 +1892,10 @@ static int _regulator_do_set_voltage(struct regulator_dev *rdev,
old_selector = ret;
delay = rdev->desc->ops->set_voltage_time_sel(rdev,
old_selector, selector);
+ if (delay < 0) {
+ rdev_warn(rdev, "set_voltage_time_sel() failed: %d\n", delay);
+ delay = 0;
+ }
}

if (best_val != INT_MAX) {
--
1.7.5.4



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/