Re: [RFC PATCH 4/8] misc: emif: add basic infrastructure for EMIFdriver

[Cousson, Benoit]

On 2/24/2012 12:10 PM, Aneesh V wrote:
> On Thursday 16 February 2012 10:00 PM, Cousson, Benoit wrote:
> > Hi Aneesh,
>
> [...]
>
> > > +struct emif_data {
> > > + u8 duplicate;
> > > + u8 temperature_level;
> > > + u32 irq;
> > > + spinlock_t lock; /* lock to prevent races */
> >
> > Nit: That comment is useless, since you already have the kerneldoc
> > comment before.
>
> Now I remember why I did that. Without that comment checkpatch gives
> this "check".
>
> CHECK: spinlock_t definition without comment
> #124: FILE: drivers/misc/emif.c:54:
> + spinlock_t lock;

That's a pretty interesting comment :-)
I guess checkpatch should be able to check for a potential kerneldoc as 
well. You might want to report that to the checkpatch maintainer.

Thanks,
Benoit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/