Re: [PATCH] x86-64: Fix CFI data for common_interrupt

[Jan Beulich]

>>> On 21.02.12 at 23:08, Mark Wielaard <mjw@xxxxxxxxxx> wrote:
> On Tue, Feb 21, 2012 at 03:26:30PM +0000, Jan Beulich wrote:
>> But provided the specification mandates this, I'm okay with the change
>> in principle. Just that specifying an offset of 0 doesn't look right then.
> 
> Yeah, I dunno what I was thinking. The offset should be set to the offset
> that was there before when rsi was pushed. The attached patch does that
> by using the same value as was used at the start of common_interrupt.
> Does that look OK?

As written before, it ought to be

	CFI_DEF_CFA		rsi,SS+8-RBP /* reg/off reset after def_cfa_expr */

With that, feel free to add

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

when you re-submit.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/