Re: [PATCH v2] USB: Support for LPC32xx SoC

From: Wolfram Sang
Date: Fri Feb 24 2012 - 01:36:03 EST



> To get rid of the remaining #ifdefs, I could as well create a new
> ohci-lpc32xx.c instead of abusing ohci-pnx4008.c. Would this be the way
> to go or are there any other suggestions?

If you could tell the difference between pnx4008 and lpc32xx, then you could
simply do something like:

if (machine_is_pnx4008)
pnx4008_configure();
else
lpc32xx_configure();

or

if (machine_is_pnx4008)
pnx4008_(un)set_usb_bits

Regards,

Wolfram

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |

Attachment: signature.asc
Description: Digital signature