Re: [PATCH v2 11/19] ARM: at91/PMC: make register base soc independent

[Ryan Mallon]

On 23/02/12 19:38, Nicolas Ferre wrote:

> On 02/22/2012 11:50 PM, Ryan Mallon :
>> On 22/02/12 20:39, Nicolas Ferre wrote:
>>
>>> From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx>
>>>
>>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx>
>>> Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
>>> Reviewed-by: Ryan Mallon <rmallon@xxxxxxxxx>
>>> ---
>>
>> <snip>
>>
>>> -	seq_printf(s, "SCSR = %8x\n", scsr = at91_sys_read(AT91_PMC_SCSR));
>>> -	seq_printf(s, "PCSR = %8x\n", pcsr = at91_sys_read(AT91_PMC_PCSR));
>>> -	seq_printf(s, "MOR  = %8x\n", at91_sys_read(AT91_CKGR_MOR));
>>> -	seq_printf(s, "MCFR = %8x\n", at91_sys_read(AT91_CKGR_MCFR));
>>> -	seq_printf(s, "PLLA = %8x\n", at91_sys_read(AT91_CKGR_PLLAR));
>>> +	seq_printf(s, "SCSR = %8x\n", scsr = at91_pmc_read(AT91_PMC_SCSR));
>>> +	seq_printf(s, "PCSR = %8x\n", pcsr = at91_pmc_read(AT91_PMC_PCSR));
>>
>>
>> I realise the original code is wrong, so doesn't need to be fixed in
>> this patch, but can we please move the assignments out of the seq_printf
>> calls.
> 
> Well, I would not say "wrong". But ugly, for sure. I queue a patch to
> correct this just before this one.


Sorry, I meant ugly rather than wrong. When I first saw it, I thought your 
replace script had made a mistake :-). 

~Ryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/