Re: [PATCH v10 05/11] seccomp: add system call filtering using BPF

[Will Drewry]

On Wed, Feb 22, 2012 at 12:32 AM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> On 02/21/2012 09:30 AM, Will Drewry wrote:
>> +
>> +/**
>> + * struct seccomp_data - the format the BPF program executes over.
>> + * @args: up to 6 system call arguments.  When the calling convention is
>> + *        32-bit, the arguments will still be at each args[X] offset.
>> + * @instruction_pointer: at the time of the system call.
>> + * @arch: indicates system call convention as an AUDIT_ARCH_* value
>> + *        as defined in <linux/audit.h>.
>> + * @nr: the system call number
>> + */
>> +struct seccomp_data {
>> +     __u64 args[6];
>> +     __u64 instruction_pointer;
>> +     __u32 arch;
>> +     int nr;
>> +};
>>
>
> This got flipped around for some reason... that is a problem if we ever
> need to extend this to more than 6 arguments (I thought we had at least
> one architecture which supported 7 arguments already, but I could just
> be delusional.)

Makes sense - I'll put it back in the proper order.

thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/