Re: [PATCH 00/10] jump label: introduce very_[un]likely + cleanups +docs

From: Ingo Molnar
Date: Wed Feb 22 2012 - 08:34:27 EST



* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> I like the blue shed, but anyway...
>
> On Wed, 2012-02-22 at 09:06 +0100, Ingo Molnar wrote:
> > * H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> >
> > > Not arguing that, but the static aspect is still key... or
> > > people will read it as another version of likely/unlikely.
> >
> > They can *read* it as such, that as is very much intentional!
>
> I mentioned this thread on irc and the first comment I received was:
>
> "is that a new attempt at trying to guide the compiler?"

It essentially is, implemented partly via compiler help,
combined with runtime code patching, as an extended run-time arm
of the compiler in essence, to make out of line slowpaths even
cheaper to have around - to make the fast-path even faster.

> I personally find the very_unlikely() confusing, but then
> again I like the blue shed over the pink one.

Confusing in what way?

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/