Re: [PATCH 2/5] staging: bcm: fix checkpatch.pl errors and warningsin Version.h

[Andy Whitcroft]

On Tue, Feb 21, 2012 at 01:10:06AM +0530, Pradheep Shrinivasan wrote:

> > Are you asking me if I'm going to NAK your patch?  No.  It's an
> > unfortunate thing.  Checkpatch.pl is going around telling people to
> > add bogus parenthesis everywhere, and no one likes to redo their
> > patches.  And I feel like a jerk for telling people that they should
> > redo their patches.  And checkpatch.pl is a robot which has more
> > energy than I do.

In theory the number of things it gets right outweigh the things it gets
wrong and you do save energy overall.

I will poke checkpatch to try and stop it getting these wrong.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/