Re: [PATCH v2 07/19] ARM: at91/pm_slowclock: function slow_clock()accepts parameters

From: Russell King - ARM Linux
Date: Wed Feb 22 2012 - 04:53:04 EST


On Wed, Feb 22, 2012 at 10:39:33AM +0100, Nicolas Ferre wrote:
> @@ -232,7 +246,7 @@ static int at91_pm_enter(suspend_state_t state)
> /* copy slow_clock handler to SRAM, and call it */
> memcpy(slow_clock, at91_slow_clock, at91_slow_clock_sz);
> #endif
> - slow_clock();
> + slow_clock(at91_pmc_base, at91_ramc0_base, at91_ramc1_base);

This should be updated to use the fncpy() stuff if there's any chance that
you'll be supporting Thumb-2. Using fncpy() is probably a good idea even
if you aren't. See asm/fncpy.h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/