Re: [PATCH] HWMON: DA9052/53 hwmon driver v2
From: Ashish Jangam
Date: Tue Feb 21 2012 - 06:51:51 EST
On Tue, 2012-02-21 at 16:48 +0530, Ashish Jangam wrote:
> On Fri, 2012-02-10 at 07:58 -0500, Ashish Jangam wrote:
> > The DA9052 PMIC provides an Analogue to Digital Converter with 10 bits
> > resolution and 10 channels.
> >
> > + * Dialog Semiconductors DA9052-BC and DA9053-AA/Bx PMICs
> > + Prefix: 'da9052'
> > + Datasheet: Kindly visit www.dialog-semiconductor.com/product_table.php
> > + and request for the official datasheet.
> > +
> Not really. From practical experience, the datasheet is not available
> except for Dialog Semiconductor customers - not even for me to review
> the driver (and that appears to be independent of my employer's
> relationship with Dialog Semiconductor). I think this should read "not
> publicly available". It is a bit misleading to suggest that it would be
> available if that is not the case.
Agreed.
>
> > +static const char * const input_names[] = {
> > + [DA9052_ADC_VDDOUT] = "VDDOUT",
> > + [DA9052_ADC_ICH] = "CHARGING CURRENT",
> > + [DA9052_ADC_TBAT] = "BATTERY TEMP",
> > + [DA9052_ADC_VBAT] = "BATTERY VOLTAGE",
> > + [DA9052_ADC_IN4] = "ADC IN4",
> > + [DA9052_ADC_IN5] = "ADC IN5",
> > + [DA9052_ADC_IN6] = "ADC IN6",
> > + [DA9052_ADC_TJUNC] = "BATTERY JUNCTION TEMP",
> > + [DA9052_ADC_VBBAT] = "BACK-UP BATTERY VOLTAGE",
> > +};
> > +
> Where are those defines, or, in other words, which repository/branch is
> your patch based on ? I don't see it in the current mainline kernel.
The incremental ADC patch to the da9052 mfd core takes care of all such
issues. However that patch is still under review...hoping to get it thru
soon.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/