Re: [PATCH v5 3/5] Extcon: support multiple states at a device.

[MyungJoo Ham]

On Mon, Feb 20, 2012 at 11:24 AM, Mark Brown
<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, Feb 10, 2012 at 03:40:36PM +0900, MyungJoo Ham wrote:
>
>> +     [EXTCON_AUDIO_IN]       = "Audio-in",
>> +     [EXTCON_AUDIO_OUT]      = "Audio-out",
>
> Can I suggest making these more specific - how about
>
>        [EXTCON_LINE_IN]        = "Line-in",
>        [EXTCON_LINE_OUT]       = "Line-out",
>        [EXTCON_MIC_IN]         = "Microphone",
>        [EXTCON_HEADPHONE_OUT]  = "Headphone",
>
> as a starting point?  The distinction between line and the other two is
> often pretty important from a UI/system interaction point of view.

Sure, this looks more generic. I'll add them along with SPDIF in/out.

>
>> +     /* TODO: remove before submit */
>> +     pr_info("[%s][%d]\n", buffer, enabled);
>
> :)

Whoops...

-- 
MyungJoo Ham, Ph.D.
System S/W Lab, Software Center, Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/