Re: [PATCH] mfd: tps65912: Initialize irq platform data properly

[Hillf Danton]

On Sun, Feb 19, 2012 at 3:50 PM, Axel Lin <axel.lin@xxxxxxxxx> wrote:
> irq_base of the tps65912 irq platform data should be
> initialized with the board provided irq_base data.
>

The description only tells what you did, but why?

> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> ---
> Âdrivers/mfd/tps65912-core.c | Â Â2 +-
> Â1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/tps65912-core.c b/drivers/mfd/tps65912-core.c
> index 5fec23a..74fd8cb 100644
> --- a/drivers/mfd/tps65912-core.c
> +++ b/drivers/mfd/tps65912-core.c
> @@ -151,7 +151,7 @@ int tps65912_device_init(struct tps65912 *tps65912)
> Â Â Â Â Â Â Â Âgoto err;
>
> Â Â Â Âinit_data->irq = pmic_plat_data->irq;
> - Â Â Â init_data->irq_base = pmic_plat_data->irq;
> + Â Â Â init_data->irq_base = pmic_plat_data->irq_base;
> Â Â Â Âret = tps65912_irq_init(tps65912, init_data->irq, init_data);
> Â Â Â Âif (ret < 0)
> Â Â Â Â Â Â Â Âgoto err;
> --
> 1.7.5.4
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/