Re: [PATCH 3/3] Staging: crystalhd: Replace the BCMLOG_ERR macrowith pr_err

[Joe Perches]

On Sat, 2012-02-18 at 09:40 +0300, Dan Carpenter wrote:
> On Fri, Feb 17, 2012 at 10:30:25PM -0800, Joe Perches wrote:
> > On Sat, 2012-02-18 at 09:25 +0300, Dan Carpenter wrote:
> > > On Fri, Feb 17, 2012 at 09:39:36PM -0200, Jorgyano Vieira wrote:
> > > > Replace the usage of BCMLOG_ERR with pr_err and remove the macro definition.
> > > This needs a pr_fmt line so we can tell where the errors are coming
> > > from.
> > > #define pr_fmt(fmt)     KBUILD_MODNAME ": %s:%d: " fmt, __func__, __LINE__
> > True.
> > __func__ and __LINE__ are not generally useful though.
> If you don't know the function and line number, then how do you
> tell all the "Invalid args" printks apart?

It's possible to add "%s...", __func__ to
the necessary uses.  Adding it to the generic
is likely overkill.

But is it really necessary anyway?

Aren't those called via some specific notifier
such that the output would make sense given
some specific invalid input?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/