Re: [PATCH v2 2/2] adi: adapt to eth_hw_addr_random() and changesin arch/blackfin

From: Joe Perches
Date: Fri Feb 17 2012 - 18:27:45 EST


On Fri, 2012-02-17 at 18:15 -0500, Mike Frysinger wrote:
> On Friday 17 February 2012 05:57:54 Danny Kukawka wrote:
> > Maybe. Many drivers already print information about setting a random mac
> > address to a netdevice. Some with printk, some via
> > netdev_warn/netdev_info/netdev_dbg or netif_dbg and other with costum
> > methods. I could unify this, in a next step with a netdev_info in
> > eth_hw_addr_random(), if it's okay for David.
> i think unification in the core makes sense. it enforces consistency and
> removes duplication.

It's a good idea.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/