Re: [PATCH 7/9] block: implement bio_associate_current()

From: Vivek Goyal
Date: Fri Feb 17 2012 - 17:34:22 EST


On Fri, Feb 17, 2012 at 02:14:06PM -0800, Tejun Heo wrote:

[..]
> If the associated blkcg is used consistently through block layer, it
> might be better but cfq doesn't even do that. It has its own icq ->
> blkcg mapping, which it initializes on first cfqq association. It
> even ignores tasks migrating to a different cgroup and keeps using
> whatever cgroup the task first issued IOs on. :(

Nope. We make note of task migration and drop cic->cfqq association
and establish a new association where new cfqq is part of new cgroup.
(ioc_cgroup_changed()).

In the past people have raised the issue of retaining the notion of
iopriority while dm targets are operating in between. This patchset
will help for that case.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/