Re: [PATCH] usb: enable pci MSI/MSIX in usb core

[Clemens Ladisch]

Alex,Shi wrote:
>> The controller driver will need to know which of the multiple MSI-X
>> interrupts has been raised:
>>
>> irqreturn_t (*msix_irq)(struct usb_hcd *hcd, unsigned int nr_or_index);
>
> Actually, hcd has 2 object for msix, msix_count and msix_entries.
>
> Do you mean msix_count maybe smaller than we decide in hcd_setup_msix()?

No.  But when msic_count > 1, we have multiple interrupts.

> Which situation will make this?

Assume that an XHCI controller has two rings, and that each one gets its
own MSI-X interrupt.  How should the driver decide which of the rings
needs to be handled?

irqreturn_t xhci_msix_irq(struct usb_hcd *hcd)
{
	struct xhci_hcd *xhci = hcd_to_xhci(hcd);

	if (...)
		handle(xhci->ring[0]);
	else
		handle(xhci->ring[1]);
}

I.e., what should go into the if()?


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/