Re: [PATCH v5 3/3] fadvise: implement POSIX_FADV_NOREUSE

From: Arun Sharma
Date: Thu Feb 16 2012 - 13:43:36 EST


On 2/16/12 2:39 AM, Andrea Righi wrote:

Arun, thank you very much for your review and testing. Probably we'll
move to a different, memcg-based solution, so I don't think I'll post
another version of this patch set as is. In case, I'll apply one of
the workarounds for the rb_root attribute.

I'm not sure if the proposed memory.file.limit_in_bytes is the right interface. Two problems:

* The user is now required to figure out what is the right amount of page cache for the app (may change over time)

* If the app touches two sets of files, one with streaming access and the other which benefits from page cache (eg: a mapper task in a map reduce), memcg doesn't allow the user to specify the access pattern per-fd.

-Arun

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/