Re: [PATCH 2/2] efi: Validate UEFI boot variables

From: Alan Cox
Date: Thu Feb 16 2012 - 09:28:44 EST


On Thu, 16 Feb 2012 08:58:37 -0500
Matthew Garrett <mjg@xxxxxxxxxx> wrote:

> A common flaw in UEFI systems is a refusal to POST triggered by a malformed
> boot variable. Once in this state, machines may only be restored by
> reflashing their firmware with an external hardware device. While this is
> obviously a firmware bug, the serious nature of the outcome suggests that
> operating systems should filter their variable writes in order to prevent
> a malicious user from rendering the machine unusable.
>
> Signed-off-by: Matthew Garrett <mjg@xxxxxxxxxx>

Other than pr_err() as a nitpick comemnt this looks good to me

Acked-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/