Re: [PATCH] watchdog: make imx2_wdt report boot status correctly

[Wolfram Sang]

Hi Oskar,

besides this minor thing (which may be just personal taste)...

> +	case WDIOC_GETBOOTSTATUS:
> +		val = __raw_readw(imx2_wdt.base + IMX2_WDT_WRSR);
> +		new_value = 0;
> +		if (val & IMX2_WDT_WRSR_TOUT)
> +			new_value = WDIOF_CARDRESET;

I'd go for this to save some lines:
		new_value = val & IMX2_WDT_WRSR_TOUT ? WDIOF_CARDRESET : 0;

But in general:

Acked-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>


-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature