Re: [PATCH 1/2] bluetooth: Use more current logging styles

[Joe Perches]

On Mon, 2012-02-13 at 07:35 +0100, Marcel Holtmann wrote:
> Why is this a good thing?

It's more similar to the rest of the <foo>_<level> uses.
Other than that, it's a little smaller.

> And in your patch we have bt_err not having \n\n in the end.

There shouldn't be a newline at all with the
actual functions bt_err or bt_info except
at the uses.

This is the style used in pr_<level> so that
it becomes possible to use pr_cont.

> Size numbers look good. So I am all for this, but not just in one big
> patch.

I think the size is more or less irrelevant.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/