Re: [PATCH 2/3] firewire-sbp2: Ignore SBP-2 targets on the localnode

[Chris Boot]

On 11/02/2012 11:56, Stefan Richter wrote:
> On Feb 10 Chris Boot wrote:
> > --- a/drivers/firewire/sbp2.c
> > +++ b/drivers/firewire/sbp2.c
> > @@ -1138,6 +1138,12 @@ static int sbp2_probe(struct device *dev)
> >   	struct Scsi_Host *shost;
> >   	u32 model, firmware_revision;
> >
> > +	/* ignore targets on the local node */
> > +	if (device->node == device->card->local_node) {
> > +		dev_set_drvdata(&unit->device, NULL);
> > +		return 0;
> > +	}
>
> I forgot:  This test can yield false negatives because card->local_node
> may change anytime.  Check device->is_local instead.

Oh. How did I miss that?! I'll get this changed...

Chris

--
Chris Boot
bootc@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/