Re: [PATCH 3/6] sep: Add interfaces for the new functions

[Hillf Danton]

On Sat, Feb 11, 2012 at 12:45 AM, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, 10 Feb 2012 21:53:50 +0800
> Hillf Danton <dhillf@xxxxxxxxx> wrote:
>
> Sorry don't see what you are pointing out. It might help if you posted
> just the small bit in question ?

Hello Alan

> Â Â Â Â Â Â Â Âif (1 == test_bit(SEP_LEGACY_SENDMSG_DONE_OFFSET,
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â&call_status->status)) {
> - Â Â Â Â Â Â Â Â Â Â Â dev_dbg(&sep->pdev->dev,
> - Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "[PID%d] dcb preparation needed before send msg\n",
> + Â Â Â Â Â Â Â Â Â Â Â dev_warn(&sep->pdev->dev,
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "[PID%d] dcb prep needed before send msg\n",
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âcurrent->pid);
> Â Â Â Â Â Â Â Â Â Â Â Âerror = -EPROTO;

Here error is assigned with -EPROTO,

> Â Â Â Â Â Â Â Â Â Â Â Âgoto end_function;
> Â Â Â Â Â Â Â Â}
>
> Â Â Â Â Â Â Â Âif (!arg) {
> - Â Â Â Â Â Â Â Â Â Â Â dev_dbg(&sep->pdev->dev,
> - Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "[PID%d] dcb prep null arg\n", current->pid);
> - Â Â Â Â Â Â Â Â Â Â Â error = -EINVAL;
> + Â Â Â Â Â Â Â Â Â Â Â dev_warn(&sep->pdev->dev,
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "[PID%d] dcb null arg\n", current->pid);
> + Â Â Â Â Â Â Â Â Â Â Â error = EINVAL;

why is EINVAL used then instead of -EINVAL?

Is this error case anything special from the above?
I guess it is typo.

Good weekend
Hillf

> Â Â Â Â Â Â Â Â Â Â Â Âgoto end_function;
> Â Â Â Â Â Â Â Â}
N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ0¶ìh®å’i