Re: [PATCH 2/2] mtd: ixp4xx: oops in ixp4xx_flash_probe
From: Marc Kleine-Budde
Date: Thu Feb 09 2012 - 08:15:53 EST
On 02/09/2012 01:11 PM, Artem Bityutskiy wrote:
> On Wed, 2012-02-08 at 20:24 +0100, Marc Kleine-Budde wrote:
>> In commit "c797533 mtd: abstract last MTD partition parser argument" the
>> third argument of "mtd_device_parse_register()" changed from start address
>> of the MTD device to a pointer to a struct.
>
> Hi, thanks for the fix. Several comments:
>
> 1. I've removed the huge oops from the description - it is not very
> helpful and not worth having.
> 2. It is usually a good idea to CC the author of the commit causing the
> regression.
> 3. For regressions like this it is a good idea put the stable tree tag.
Noted.
> I've added
>
> Cc: stable@xxxxxxxxxx [3.2+]
>
> (git tag --contains c797533 gives the version)
>
> and pushed to the l2-mtd.git tree, thanks!
Thanks
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Attachment:
signature.asc
Description: OpenPGP digital signature