Re: [PATCH 2/3][RFC] x86/tracing: Denote the power and cpuidletracepoints as _rcuidle()

From: Paul E. McKenney
Date: Tue Feb 07 2012 - 17:54:34 EST


On Tue, Feb 07, 2012 at 09:56:55AM -0500, Steven Rostedt wrote:
> From: Steven Rostedt <srostedt@xxxxxxxxxx>
>
> The power and cpuidle tracepoints are called within a rcu_idle_exit()
> section, and must be denoted with the _rcuidle() version of the tracepoint.
>
> Cc: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

(Sorry, fat-fingered this one the first time around.)

Acked-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>

> ---
> arch/x86/kernel/process.c | 24 ++++++++++++------------
> 1 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
> index 15763af..44eefde 100644
> --- a/arch/x86/kernel/process.c
> +++ b/arch/x86/kernel/process.c
> @@ -377,8 +377,8 @@ static inline int hlt_use_halt(void)
> void default_idle(void)
> {
> if (hlt_use_halt()) {
> - trace_power_start(POWER_CSTATE, 1, smp_processor_id());
> - trace_cpu_idle(1, smp_processor_id());
> + trace_power_start_rcuidle(POWER_CSTATE, 1, smp_processor_id());
> + trace_cpu_idle_rcuidle(1, smp_processor_id());
> current_thread_info()->status &= ~TS_POLLING;
> /*
> * TS_POLLING-cleared state must be visible before we
> @@ -391,8 +391,8 @@ void default_idle(void)
> else
> local_irq_enable();
> current_thread_info()->status |= TS_POLLING;
> - trace_power_end(smp_processor_id());
> - trace_cpu_idle(PWR_EVENT_EXIT, smp_processor_id());
> + trace_power_end_rcuidle(smp_processor_id());
> + trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, smp_processor_id());
> } else {
> local_irq_enable();
> /* loop is done by the caller */
> @@ -450,8 +450,8 @@ EXPORT_SYMBOL_GPL(cpu_idle_wait);
> static void mwait_idle(void)
> {
> if (!need_resched()) {
> - trace_power_start(POWER_CSTATE, 1, smp_processor_id());
> - trace_cpu_idle(1, smp_processor_id());
> + trace_power_start_rcuidle(POWER_CSTATE, 1, smp_processor_id());
> + trace_cpu_idle_rcuidle(1, smp_processor_id());
> if (this_cpu_has(X86_FEATURE_CLFLUSH_MONITOR))
> clflush((void *)&current_thread_info()->flags);
>
> @@ -461,8 +461,8 @@ static void mwait_idle(void)
> __sti_mwait(0, 0);
> else
> local_irq_enable();
> - trace_power_end(smp_processor_id());
> - trace_cpu_idle(PWR_EVENT_EXIT, smp_processor_id());
> + trace_power_end_rcuidle(smp_processor_id());
> + trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, smp_processor_id());
> } else
> local_irq_enable();
> }
> @@ -474,13 +474,13 @@ static void mwait_idle(void)
> */
> static void poll_idle(void)
> {
> - trace_power_start(POWER_CSTATE, 0, smp_processor_id());
> - trace_cpu_idle(0, smp_processor_id());
> + trace_power_start_rcuidle(POWER_CSTATE, 0, smp_processor_id());
> + trace_cpu_idle_rcuidle(0, smp_processor_id());
> local_irq_enable();
> while (!need_resched())
> cpu_relax();
> - trace_power_end(smp_processor_id());
> - trace_cpu_idle(PWR_EVENT_EXIT, smp_processor_id());
> + trace_power_end_rcuidle(smp_processor_id());
> + trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, smp_processor_id());
> }
>
> /*
> --
> 1.7.8.3
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/