Re: [PATCH -v2] x86, mm: Probe memory block size for generic x8664bit

[H. Peter Anvin]

On 01/30/2012 12:24 AM, Yinghai Lu wrote:
> Usually if the system support memory remapping to get back memory for mmio
> range, we will have 128M ... 2G at the end.
> 
> Try to probe that size.
> 
> So we can get less entries in /sys/devices/system/memory/
> 
> -v2: don't probe it every time when /sys/../block_size_byte is showed...
> 

Okay... what on Earth is the point of this?

This just screams "dangerous toxic heuristic that's likely to break
unusual configurations", and reducing the number of entries in a /sys
directory is hardly motivation for anything.

You need a much better description of what you're trying to accomplish
and why that matters in the first place.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/