Re: [PATCH v5 16/18] perf: enable reading of files fromdifferent ABI rev

From: Arnaldo Carvalho de Melo
Date: Tue Feb 07 2012 - 09:53:10 EST

Em Tue, Feb 07, 2012 at 12:33:02PM +0530, Anshuman Khandual escreveu:
> On Monday 06 February 2012 11:52 PM, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Feb 02, 2012 at 01:54:46PM +0100, Stephane Eranian escreveu:
> >> This patch allows perf to process files generated
> >> using an ABI that has a different perf_event_attr struct size, i.e.,
> >> a different ABI version.

> > Anshuman, can I have your Acked-by or Reviewed-by since you spotted
> > problems in this and your suggestions were taken into account? Is this
> > OK now?

> (1) PERF_SAMPLE_BRANCH_HV and related privilege level problems has been fixed.
> Verified various combinations of <branch_type>,[u,k,hv] <event>:[u,k,h].
> Works well in all privilege level permutations.
> (2) As Peter has mentioned 'has_branch_smpl()' bug in the ARM code would be taken
> care.
> (3) 'ref_size' problem in try_all_pipe_abis() has been fixed. All the patches
> independently compile successfully.
> (4) Went through the entire patchset, looks good to me.
> Acked-by: Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx>
> Tested-by: Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx>

Thanks! But we'll now have to wait till Stephane addresses the points
made by David :-)

- Arnaldo
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at