RE: [PATCH 01/11] dmaengine: add context parameter toprep_slave_sgand prep_dma_cyclic
From: Bounine, Alexandre
Date: Tue Feb 07 2012 - 09:19:22 EST
On Tue, Feb 07, 2012 9:14 AM, Vinod Koul wrote:
> On Tue, 2012-02-07 at 06:01 -0800, Bounine, Alexandre wrote:
> > Currently function private_candidate() allows filtering function
> > not to be specified and therefore skip the filter check.
> > It may be a good safety measure to ensure that channels specified
> > as DMA_SLAVE_EXT provide a corresponding filter routine so they
> > positively identify dma channel that will accept intended extra
> > parameter.
> > I assume that a system may have more than one dmac registered as
> > DMA_SLAVE_EXT.
> > This is what I have for RapidIO - the filter call ensures that DMA
> > channel is associated with a RapidIO controller that provides access
> > to the specified SRIO device.
> For slave-dma it's better to have a filter :)
Better, but it can get away without it ;))