Re: [PATCH v2 2/7] MFD: twl6040: Convert to i2c driver, and separateit from twl core

From: Mark Brown
Date: Tue Feb 07 2012 - 08:29:26 EST

On Tue, Feb 07, 2012 at 03:01:13PM +0200, Peter Ujfalusi wrote:
> Complete the separation of the twl6040 from the twl core since
> it is a separate chip, not part of the twl6030 PMIC.

Looking good

Reviewed-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxx>

and it looks like you'll save a bunch more code if you're able to
convert over to using a regmap cache. Note that as a first pass you
just need to define which registers are volatile and enable a cache type
- if defaults are omitted then the values will be read back from the
device to start off with.

Attachment: signature.asc
Description: Digital signature