Re: [PATCH 90/91] block: fail SCSI passthrough ioctls on partition devices

From: Willy Tarreau
Date: Tue Feb 07 2012 - 05:21:22 EST

Hi Paolo,

On Tue, Feb 07, 2012 at 11:03:03AM +0100, Paolo Bonzini wrote:
> On 02/05/2012 11:53 PM, Willy Tarreau wrote:
> >Thanks for this report, I missed this patch. I thought the reason for the
> >lack
> >of scsi_cmd_blk_ioctl() it was one of the differences between 2.6.27 and
> >2.6.32,
> >so I have adapted the callers I identified to perform the same test as
> >what's
> >in scsi_cmd_blk_ioctl().
> There were other callers in patch 1/3, most notably virtio-blk, that are
> not in your patch.

Yes it was, just like ub, sd and ide-floppy. In fact backport this whole patch
was the trickiest task as I had to review each caller one after the other, and
I'm quite confident the result is fine. But I prefer to redo it from scratch
with your original patch that I missed, as it will wipe any doubts and make
further maintenance easier.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at