Re: [PATCH 2/3] i2c: Add Congatec CGEB I2C driver

[Wolfram Sang]

Hi Sascha,

> +config I2C_CONGATEC_CGEB
> +	tristate "Congatec CGEB I2C driver"
> +	depends on MFD_CONGATEC_CGEB
> +	help
> +	  This driver provides support for the I2C busses accssable via
> +	  the Congatec CGEB interface found on Congatec boards.
> +

Please keep the sorting (eg20t is wrong and will be fixed).

> +		ret = cgeb_call(priv->board, &fps, CgebI2CTransfer);
> +		if (ret) {
> +			ret = -EREMOTEIO;
> +			goto out;
> +		}

-EREMOTEIO is not present in Documentation/i2c/fault-codes. Please use
one from that file.

> +	ret = cgeb_i2c_set_speed(priv, 400000);
> +	if (ret)
> +		/*
> +		 * not a critical error, we can continue with the default speed.
> +		 */
> +		dev_warn(&pdev->dev, "Could not set speed to 400KHz\n");

Is it possible to make this configurable? Not all I2C devices support
400KHz, 100KHz is OK.

> +static struct platform_driver cgeb_i2c_driver = {
> +	.probe		= cgeb_i2c_probe,
> +	.remove		= __exit_p(cgeb_i2c_remove),

__devexit_p()

> +static int __init cgeb_i2c_driver_init(void)
> +{
> +	return platform_driver_register(&cgeb_i2c_driver);
> +}
> +
> +static void __exit cgeb_i2c_driver_exit(void)
> +{
> +	platform_driver_unregister(&cgeb_i2c_driver);
> +}
> +
> +module_init(cgeb_i2c_driver_init);
> +module_exit(cgeb_i2c_driver_exit);

module_platform_driver();

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature