Re: [PATCH v2 2/6] oom: Get rid of sparse warnings

From: KOSAKI Motohiro
Date: Tue Feb 07 2012 - 00:39:49 EST

>> task struct only have allock_lock, not alloc_loc.
> Funnily, but sparse does not care. :-) __release(foo) will work as
> well. Seems like sparse counts locking balance globally.
> This is now fixed in the patch down below, thanks for catching.
>> Moreover we don't release
>> the lock in this code path. Seems odd.
> Indeed. That's exactly what sparse seeing is as well. We exit
> without releasing the lock, which is bad (in sparse' eyes). So
> we lie to sparse, telling it that we do release, so it shut ups.


To be honest, I really dislike any lie annotation. Why? It is very
fragile and easily
become broken from unrelated but near line changes. Please consider to
enhance sparse at first.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at