Re: linux-next: build failure after merge of the l2-mtd tree

From: Stephen Rothwell
Date: Mon Feb 06 2012 - 16:10:35 EST


Hi Artem,

On Mon, 06 Feb 2012 11:14:14 +0200 Artem Bityutskiy <dedekind1@xxxxxxxxx> wrote:
>
> On Mon, 2012-02-06 at 12:07 +1100, Stephen Rothwell wrote:
> >
> > drivers/mtd/devices/pmc551.c:191:12: error: conflicting types for 'pmc551_unpoint'
> > include/linux/mtd/pmc551.h:37:13: note: previous declaration of 'pmc551_unpoint' was here
> > drivers/mtd/devices/pmc551.c: In function 'pmc551_unpoint':
> > drivers/mtd/devices/pmc551.c:196:1: warning: no return statement in function returning non-void [-Wreturn-type]
>
> Thanks, fixed. I am doing rather massive MTD API cleaning, so new small
> issues are possible.

You fixed the header file, but not the fact that pmc551_unpoint() still
doesn't return anything ... Warnings are there for a reason sometimes :-)

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature