Re: [PATCH v5 2/5] netdev: ethernet dev_alloc_skb tonetdev_alloc_skb

From: David Miller
Date: Mon Feb 06 2012 - 11:49:19 EST


From: "Pradeep A. Dalvi" <netdev@xxxxxxxxxxxxxxxx>
Date: Sun, 5 Feb 2012 18:20:10 +0530

> From: Pradeep A Dalvi <netdev@xxxxxxxxxxxxxxxx>
>
> Replaced deprecating dev_alloc_skb with netdev_alloc_skb in drivers/net/ethernet
> - Removed extra skb->dev = dev after netdev_alloc_skb
>
> Signed-off-by: Pradeep A Dalvi <netdev@xxxxxxxxxxxxxxxx>

Applied, but again I had to fix things:

> - p = dev_alloc_skb(IEEE802_3_SZ + DE4X5_ALIGN + 2);
> + p = netdev_alloc_skb(dev, IEEE802_3_SZ + DE4X5_ALIGN + 2);
...
> - p = dev_alloc_skb(len + 2);
> + p = netdev_alloc_skb(dev, len + 2);

Leave existing indentation alone.

> - skb = dev_alloc_skb(ugeth->ug_info->uf_info.max_rx_buf_length +
> - UCC_GETH_RX_DATA_BUF_ALIGNMENT);
> + skb = netdev_alloc_skb(ugeth->ndev,
> + ugeth->ug_info->uf_info.max_rx_buf_length +
> + UCC_GETH_RX_DATA_BUF_ALIGNMENT);

Line up subsequent lines of a multiline series of function arguments
properly, each should start at the first column after the function calls
openning parenthesis.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/