Re: [PATCH 05/15] mm: compaction: export some of the functions

From: Hillf Danton
Date: Mon Feb 06 2012 - 07:46:52 EST


2012/2/5 Michal Nazarewicz <mina86@xxxxxxxxxx>:
>> On Fri, Feb 3, 2012 at 8:18 PM, Marek Szyprowski
>> <m.szyprowski@xxxxxxxxxxx> wrote:
>>>
>>> From: Michal Nazarewicz <mina86@xxxxxxxxxx>
>>>
>>> This commit exports some of the functions from compaction.c file
>>> outside of it adding their declaration into internal.h header
>>> file so that other mm related code can use them.
>>>
>>> This forced compaction.c to always be compiled (as opposed to being
>>> compiled only if CONFIG_COMPACTION is defined) but as to avoid
>>> introducing code that user did not ask for, part of the compaction.c
>>> is now wrapped in on #ifdef.
>
>
> On Sun, 05 Feb 2012 08:40:08 +0100, Hillf Danton <dhillf@xxxxxxxxx> wrote:
>>
>> What if both compaction and CMA are not enabled?
>
>
> What about it? ÂIf both are enabled, both will be compiled and usable.
>

Better if enforced compilation of compaction is addressed in separate
patch in the patchset, according to the rule that one patch is delivered
with one issue concerned.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/