Re: [PATCH v9 00/25] gpio/omap: driver cleanup and fixes
From: DebBarma, Tarun Kanti
Date: Mon Feb 06 2012 - 06:53:18 EST
On Sat, Feb 4, 2012 at 2:31 AM, Kevin Hilman <khilman@xxxxxx> wrote:
> Hi Tarun,
> Tarun Kanti DebBarma <tarun.kanti@xxxxxx> writes:
> > The following changes since commit 62aa2b537c6f5957afd98e29f96897419ed5ebab:
> > Linus Torvalds (1):
> > Linux 3.3-rc2
> > are available in the git repository at:
> > http://gitorious.org/~tarunkanti/omap-sw-develoment/tarunkantis-linux-omap-dev
> > Branch: for_3.4/gpio_cleanup_fixes_v9
> > This series is continuation of cleanup of OMAP GPIO driver and fixes.
> > The cleanup include getting rid of cpu_is_* checks wherever possible,
> > use of gpio_bank list instead of static array, use of unique platform
> > specific value associated data member to OMAP platforms to avoid
> > cpu_is_* checks. The series also include PM runtime support.
> This version is looking pretty good, and I'm almost ready to queue it up
> for Grant.
> However, one more minor nit. Please fix up the compile warnings when
> built without CONFIG_PM_SLEEP or CONFIG_PM_RUNTIME.
> The definitons of the dev_pm_ops callbacks need to be conditional when
> using the SET_*_PM_OPS() macros, otherwise you get these warnings:
I have updated the branch with the required changes.
> CC drivers/gpio/gpio-omap.o
> /work/kernel/omap/pm/drivers/gpio/gpio-omap.c:1142:12: warning: 'omap_gpio_suspend' defined but not used [-Wunused-function]
> /work/kernel/omap/pm/drivers/gpio/gpio-omap.c:1167:12: warning: 'omap_gpio_resume' defined but not used [-Wunused-function]
> /work/kernel/omap/pm/drivers/gpio/gpio-omap.c:1191:12: warning: 'omap_gpio_runtime_suspend' defined but not used [-Wunused-function]
> /work/kernel/omap/pm/drivers/gpio/gpio-omap.c:1237:12: warning: 'omap_gpio_runtime_resume' defined but not used [-Wunused-function]
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/