Re: [PATCH 55/91] Make scsi_free_queue() kill pending SCSI commands

[Willy Tarreau]

On Mon, Feb 06, 2012 at 08:28:48AM +0100, Bart Van Assche wrote:
> On Sun, Feb 5, 2012 at 11:10 PM, Willy Tarreau <w@xxxxxx> wrote:
> >
> > 2.6.27-longterm review patch.  If anyone has any objections, please let us know.
> >
> > ------------------
> >
> > commit 3308511c93e6ad0d3c58984ecd6e5e57f96b12c8 upstream.
> >
> > Make sure that SCSI device removal via scsi_remove_host() does finish
> > all pending SCSI commands. Currently that's not the case and hence
> > removal of a SCSI host during I/O can cause a deadlock. See also
> > "blkdev_issue_discard() hangs forever if underlying storage device is
> > removed" (http://bugzilla.kernel.org/show_bug.cgi?id=40472). See also
> > http://lkml.org/lkml/2011/8/27/6.
> 
> If you backport that commit, you should backport commit
> 745718132c3c7cac98a622b610e239dcd5217f71 too. See e.g.
> http://lkml.org/lkml/2011/11/8/22.

Thank you Bart, I thought it was just cosmetic. Queued now.

Cheers,
Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/