Re: [PATCH 18/21] PCI: Fix cardbus bridge resources as optional size handling
From: Yinghai Lu
Date: Sun Feb 05 2012 - 18:30:41 EST
On Sun, Feb 5, 2012 at 1:58 PM, Dominik Brodowski
> On Fri, Jan 27, 2012 at 01:37:44PM -0800, Yinghai Lu wrote:
>> On Fri, Jan 27, 2012 at 10:23 AM, Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote:
>> > On Sat, 21 Jan 2012 02:08:34 -0800
>> > Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>> >> We should not set the requested size to -2.
>> >> that will confuse the resource list sorting with align when SIZEALIGN is used.
>> >> Change to STARTALIGN and pass align from start.
>> >> We are safe to do that just as we do that regular pci bridge.
>> >> In the long run, we should just treat cardbus like regular pci bridge.
>> >> Also fix when realloc is not passed, should keep the requested size.
>> >> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
>> > I'd like to see some testing on this one... Dominik?
>> Can you please test branch at
> Tested this on my limited test systems (COUNT=1), and seems to work fine.
Thanks a lot.
Thought that you should have bunch of systems (laptop) with pci cardbus slots.
Found another regression by one commit already got into linus' tree.
and should be fixed by
[PATCH] pci: Fix pci cardbus removal
please double check
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/