[PATCH 60/91] Make TASKSTATS require root access

From: Willy Tarreau
Date: Sun Feb 05 2012 - 17:39:31 EST

2.6.27-longterm review patch. If anyone has any objections, please let us know.


commit 1a51410abe7d0ee4b1d112780f46df87d3621043 upstream.

Ok, this isn't optimal, since it means that 'iotop' needs admin
capabilities, and we may have to work on this some more. But at the
same time it is very much not acceptable to let anybody just read
anybody elses IO statistics quite at this level.

Use of the GENL_ADMIN_PERM suggested by Johannes Berg as an alternative
to checking the capabilities by hand.

Reported-by: Vasiliy Kulikov <segoon@xxxxxxxxxxxx>
Cc: Johannes Berg <johannes.berg@xxxxxxxxx>
Acked-by: Balbir Singh <bsingharora@xxxxxxxxx>
Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Cc: Moritz Mühlenhoff <jmm@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
kernel/taskstats.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

Index: longterm-2.6.27/kernel/taskstats.c
--- longterm-2.6.27.orig/kernel/taskstats.c 2012-02-05 22:34:33.153915196 +0100
+++ longterm-2.6.27/kernel/taskstats.c 2012-02-05 22:34:43.419915481 +0100
@@ -574,6 +574,7 @@
.doit = taskstats_user_cmd,
.policy = taskstats_cmd_get_policy,
+ .flags = GENL_ADMIN_PERM,

static struct genl_ops cgroupstats_ops = {

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/