[PATCH 45/91] aacraid: reset should disable MSI interrupt

From: Willy Tarreau
Date: Sun Feb 05 2012 - 17:28:44 EST


2.6.27-longterm review patch. If anyone has any objections, please let us know.

------------------

commit d0efab26f89506387a1bde898556660e06d7eb15 upstream.

scsi reset on hardware with enabled MSI interrupts generates WARNING message

[11027.798722] aacraid: Host adapter abort request (0,0,0,0)
[11027.798814] aacraid: Host adapter reset request. SCSI hang ?
[11087.762237] aacraid: SCSI bus appears hung
[11135.082543] ------------[ cut here ]------------
[11135.082646] WARNING: at drivers/pci/msi.c:658 pci_enable_msi_block+0x251/0x290()

Signed-off-by: Vasily Averin <vvs@xxxxx>
Acked-by: Mark Salyzyn <mark_salyzyn@xxxxxxxxxxxxxx>
Signed-off-by: James Bottomley <JBottomley@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
---
drivers/scsi/aacraid/commsup.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

Index: longterm-2.6.27/drivers/scsi/aacraid/commsup.c
===================================================================
--- longterm-2.6.27.orig/drivers/scsi/aacraid/commsup.c 2012-02-05 22:34:33.642915831 +0100
+++ longterm-2.6.27/drivers/scsi/aacraid/commsup.c 2012-02-05 22:34:41.243915381 +0100
@@ -1202,6 +1202,8 @@
kfree(aac->queues);
aac->queues = NULL;
free_irq(aac->pdev->irq, aac);
+ if (aac->msi)
+ pci_disable_msi(aac->pdev);
kfree(aac->fsa_dev);
aac->fsa_dev = NULL;
quirks = aac_get_driver_ident(index)->quirks;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/