Re: [PATCH, v2] checkpatch: Warn on code with 6+ tab indentation,remove 80col warning
From: Ingo Molnar
Date: Sun Feb 05 2012 - 13:14:41 EST
* Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Sun, 2012-02-05 at 12:38 +0100, Ingo Molnar wrote:
> > In practice patch submitters take warnings just as
> > seriously.
> In practice, that's not necessarily bad.
In practice it *is* bad, and I say that as a maintainer who is
receiving many checkpatch 'fixes' on a daily basis. Many
checkpatch warnings are legitimate - but the col80 one is bogus
in many cases.
Bogus warnings pollute the output of the tool, reducing the
utility of the *other* warnings.
( GCC frequently made this mistake in the past, emitting dubious
warnings by default - it's been getting somewhat better
So if your patch emits no warning for the col80 thing then
that's a step forward in the right direction in my opinion.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/