Re: [PATCH, v2] checkpatch: Warn on code with 6+ tab indentation,remove 80col warning
From: Joe Perches
Date: Sat Feb 04 2012 - 13:48:21 EST
On Sat, 2012-02-04 at 19:02 +0100, Ingo Molnar wrote:
> * Joe Perches <joe@xxxxxxxxxxx> wrote:
> > On Sat, 2012-02-04 at 14:03 +0100, Ingo Molnar wrote:
> > > * Joe Perches <joe@xxxxxxxxxxx> wrote:
> > > > Overly indented code should be refactored.
> > > _AND_ the 80 cols warning should be removed. The overwhelming
> > > majority of developers either ignore the 80 cols warning or make
> > > the code worse as a result of the warning.
> > Perhaps, but it should be a separate patch
> > and you'd still need to update CodingStyle.
> Why would I have to update CodingStyle? The 80col limit remains,
> it's just removed from *checkpatch*.
If that's your intent, I disagree with your patch.
There are some truly _ugly_ > 80 char lines that
people attempt where checkpatch should issue some
"don't do that" message.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/