Re: [PATCH 02/15] PCI: Add iobusn_resource

From: Yinghai Lu
Date: Fri Feb 03 2012 - 21:30:43 EST


On Fri, Feb 3, 2012 at 3:38 PM, Benjamin Herrenschmidt
<benh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, 2012-02-03 at 08:36 -0800, Bjorn Helgaas wrote:
>> On Wed, Feb 1, 2012 at 2:43 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>> > also add busn_res into struct pci_bus.
>> >
>> > will use them to have bus number resource tree.
>>
>> Will you make this tree visible in /proc?  Seems like that would be
>> useful for debugging and for symmetry with /proc/iomem and
>> /proc/ioports.
>
> To be honest that whole business with bus numbers in struct resource
> seems like gratuituous bloat & over engineering to me ...

ah, i thought it is simple enough, and should be done before already.

> Does it actually solve a specific problem or serve a purpose ?

very beginning is for one IBM x3950...

https://bugzilla.novell.com/show_bug.cgi?id=735909

++max searching valid bus number range is out of boundary of peer root
bus range.

later, found the code could help: pcie hotplug, pci bus rescan and
even remove some hacks for/from cardbus field.

now with this patchset (+ one patch that is not sent out yet), I could
even use setpci/pci rescan to move pci bus around.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/