Re: [PATCH 02/15] PCI: Add iobusn_resource

From: Yinghai Lu
Date: Fri Feb 03 2012 - 12:19:17 EST


On Fri, Feb 3, 2012 at 8:36 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> On Wed, Feb 1, 2012 at 2:43 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>> also add busn_res into struct pci_bus.
>>
>> will use them to have bus number resource tree.
>
> Will you make this tree visible in /proc?  Seems like that would be
> useful for debugging and for symmetry with /proc/iomem and
> /proc/ioports.

will give it try.

>
...
>> @@ -419,6 +419,7 @@ struct pci_bus {
>>        struct list_head slots;         /* list of slots on this bus */
>>        struct resource *resource[PCI_BRIDGE_RESOURCE_NUM];
>>        struct list_head resources;     /* address space routed to this bus */
>> +       struct resource busn_res;       /* track registered bus num range */
>
> Is this different from bus.secondary and bus.subordinate?  Do we need
> both busn_res and secondary/subordinate?  If we need both, in what
> circumstance with they contain different information?

yes, sometime it

for non-peer root bus just after scan. and at that time will set
busn_res.end correctly according to subordinate.

for peer root bus, busn_res.end could be bigger than bus subordinate

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/