Re: [PATCH 07/07] ONKEY: OnKey module for DA9052/53 PMIC v1

From: Mark Brown
Date: Fri Feb 03 2012 - 08:52:17 EST

On Fri, Feb 03, 2012 at 06:54:06PM +0530, Ashish Jangam wrote:
> On Fri, 2012-02-03 at 17:28 +0530, Ashish Jangam wrote:

As *repeatetly* mentioned please fix the word wrapping in your mailer.

> > That doesn't seem to address the concern. You're setting ret in exactly one place
> > and scheduling the work in exactly one place, why are these two things split?

> schedule_delayed_work() is conditional because it should get invoke
> when onkey button is pressed and not when released. For this reason
> onkey event is first queried and work is scheduled only when event is
> present. Now when work is scheduled, onkey event gets queried and in
> absence of the onkey event work will not get schedule again. By this
> logic I'm able to simulated the release of the onkey button.

You're once more completely missing my point. You've got a conditional
which detects if the button is pressed in which you set a flag which is
checked later to see if you should also schedule the work. Since the
only thing that ever sets that flag is the button being pressed having
the flag seems pointless, you may as well just schedule the work instead
of setting the flag.

Attachment: signature.asc
Description: Digital signature