Re: [Patch] mips: do not redefine BUILD_BUG()

[Geert Uytterhoeven]

On Fri, Feb 3, 2012 at 11:29, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote:
>> include/linux/kernel.h:717:1: error: "BUILD_BUG" redefined
>> arch/mips/include/asm/page.h:43:1: error: this is the location of the
>> previous definition

>> --- a/arch/mips/include/asm/page.h
>> +++ b/arch/mips/include/asm/page.h
>> @@ -39,9 +39,7 @@
>> Â#define HPAGE_MASK Â Â(~(HPAGE_SIZE - 1))
>> Â#define HUGETLB_PAGE_ORDER Â Â(HPAGE_SHIFT - PAGE_SHIFT)
>> Â#else /* !CONFIG_HUGETLB_PAGE */
>> -# ifndef BUILD_BUG
>
> Â Not clear why we get the error if we're protected with #ifndef...

Because this is the first definition. It's redefined later.

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/