Re: [PATCH 1/3 v2] pch_udc: Detecting VBUS through GPIO

From: Felipe Balbi
Date: Fri Feb 03 2012 - 02:32:53 EST


Hi,

On Fri, Feb 03, 2012 at 04:35:26PM +0900, Tomoya MORINAGA wrote:
> Problem:
> In USB Suspend, pch_udc handles 'disconnect'.
>
> Root cause:
> The current pch_udc is not monitoring VBUS.
> When USB cable is disconnected, USB Device Controller generates
> an interrupt of USB Suspend.
> pch_udc cannot distinguish it is USB Suspend or disconnect.
> Therefore, pch_udc handles 'disconnect' after an interrupt of
> USB Suspend happend.
>
> Solution:
> VBUS is detected through GPIO.
> After an interrupt produced USB Suspend, if VBUS is Low,
> pch_udc handles 'disconnect'.
> If VBUS is High, pch_udc handles 'suspend'.
>
> Signed-off-by: Tomoya MORINAGA <tomoya.rohm@xxxxxxxxx>

Next time, please reply to the v1 of the patch. git send-email has this
--in-reply-to option which helps with that ;-)

--
balbi

Attachment: signature.asc
Description: Digital signature