Re: [PATCH 06/11] blkcg: move refcnt to blkcg core

From: Vivek Goyal
Date: Thu Feb 02 2012 - 17:07:18 EST


On Wed, Feb 01, 2012 at 01:19:11PM -0800, Tejun Heo wrote:
> Currently, blkcg policy implementations manage blkg refcnt duplicating
> mostly identical code in both policies. This patch moves refcnt to
> blkg and let blkcg core handle refcnt and freeing of blkgs.
>
> * cfq blkgs now also get freed via RCU.

This can lead to situation where cfq root group (policy data) is still
around (yet to be freed after rcu perioed) but cfq has gone away
(cfq_exit_queue() followed by cfq_exit()). Does it matter? If some future
code is accessing cfqg under rcu, it can become a problem.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/