Re: [PATCHSET] blkcg: unify blkgs for different policies

From: Vivek Goyal
Date: Thu Feb 02 2012 - 14:30:05 EST

On Wed, Feb 01, 2012 at 01:19:05PM -0800, Tejun Heo wrote:

> * use unified stats updated under queue lock and drop percpu stats
> which should fix locking / context bug across percpu allocation.

Hi Tejun,

Does that mean that stat updation will happen under queue lock even if
there are no throttling rules? That will introduce extra queue lock on
fast path those who have throttling compiled in but are not using (common
case for distributions).

IMHO, we should keep the lockless per cpu stats and do the allocation in
worker thread. I was going through my messages and noticed that for
a workload queue lock contention had come down by 11% and in a separate
testing I could gain 4-5% with PCIe based flash drive for random reads
while I saturated the cpus.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at